From 44cc32326806d9f2ee6bf7b0fe6b6359e53a4e77 Mon Sep 17 00:00:00 2001 From: "Brian S. O'Neill" Date: Mon, 3 Sep 2007 17:13:02 +0000 Subject: Calling Storable.update when there are no dirty properties actually does an update instead of being "smart" and ignoring the update request. The old behavior was non-intuitive and interfered with expected trigger behavior. --- src/test/java/com/amazon/carbonado/TestStorables.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'src/test/java/com') diff --git a/src/test/java/com/amazon/carbonado/TestStorables.java b/src/test/java/com/amazon/carbonado/TestStorables.java index 795318b..de0bba4 100644 --- a/src/test/java/com/amazon/carbonado/TestStorables.java +++ b/src/test/java/com/amazon/carbonado/TestStorables.java @@ -718,9 +718,9 @@ public class TestStorables extends TestCase { assertEquals(2, s.getVersion()); assertEquals("world", s.getValue()); - // Since no properties changed, update does not increase version. + // Even if no properties changed, update increases version. assertEquals(true, s.tryUpdate()); - assertEquals(2, s.getVersion()); + assertEquals(3, s.getVersion()); // Simple test to ensure that version property doesn't need to be // dirtied. @@ -770,9 +770,9 @@ public class TestStorables extends TestCase { assertEquals(2, s.getVersion()); assertEquals("world", s.getValue()); - // Since no properties changed, update does not increase version. + // Even if no properties changed, update increases version. assertEquals(true, s.tryUpdate()); - assertEquals(2, s.getVersion()); + assertEquals(3, s.getVersion()); } public void test_versioningWithObj() throws Exception { @@ -822,9 +822,9 @@ public class TestStorables extends TestCase { assertEquals((Integer) 2, s.getVersion()); assertEquals("value", s.getValue()); - // Since no properties changed, update does not increase version. + // Even if no properties changed, update increases version. assertEquals(true, s.tryUpdate()); - assertEquals((Integer) 2, s.getVersion()); + assertEquals((Integer) 3, s.getVersion()); } public void test_versioningWithLongObj() throws Exception { @@ -874,9 +874,9 @@ public class TestStorables extends TestCase { assertEquals((Long) 2L, s.getVersion()); assertEquals("value", s.getValue()); - // Since no properties changed, update does not increase version. + // Even if no properties changed, update increases version. assertEquals(true, s.tryUpdate()); - assertEquals((Long) 2L, s.getVersion()); + assertEquals((Long) 3L, s.getVersion()); } public void test_initialVersion() throws Exception { -- cgit v1.2.3