Merge pull request #1 from Carbonado/fix-jdbc-leakHEADmaster

Adding tests for the JDBCTransactionManager.

2 files changed, 171 insertions, 4 deletions

diff --git a/pom.xml b/pom.xml
index 1feb726..9c240f6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -5,7 +5,7 @@
   <artifactId>carbonado-test-suite</artifactId>

   <packaging>jar</packaging>

   <name>CarbonadoTestSuite</name>

-  <version>1.2.3</version>

+  <version>1.2.4</version>

   <description>

     Test suite for Carbonado.

   </description>

@@ -69,21 +69,21 @@
     <dependency>

       <groupId>com.amazon.carbonado</groupId>

       <artifactId>carbonado</artifactId>

-      <version>1.2.3</version>

+      <version>[1.2.4,)</version>

       <scope>test</scope>

     </dependency>

 

     <dependency>

       <groupId>com.amazon.carbonado</groupId>

       <artifactId>carbonado-sleepycat-je</artifactId>

-      <version>1.2.3</version>

+      <version>[1.2.4,)</version>

       <scope>test</scope>

     </dependency>

 

     <dependency>

       <groupId>com.amazon.carbonado</groupId>

       <artifactId>carbonado-sleepycat-db</artifactId>

-      <version>1.2.3</version>

+      <version>[1.2.4,)</version>

       <scope>test</scope>

     </dependency>

 

@@ -121,6 +121,13 @@
       <version>4.7</version>

       <scope>test</scope>

     </dependency>

+

+    <dependency>

+      <groupId>org.easymock</groupId>

+      <artifactId>easymock</artifactId>

+      <version>[3.3,)</version>

+      <scope>test</scope>

+    </dependency>

   </dependencies>

 

   <build>

diff --git a/src/test/java/com/amazon/carbonado/repo/jdbc/TestJDBCTransactionManager.java b/src/test/java/com/amazon/carbonado/repo/jdbc/TestJDBCTransactionManager.java
new file mode 100644
index 0000000..e149295
--- /dev/null
+++ b/src/test/java/com/amazon/carbonado/repo/jdbc/TestJDBCTransactionManager.java
@@ -0,0 +1,160 @@
+/*
+ * Copyright 2008-2015 Amazon Technologies, Inc. or its affiliates.
+ * Amazon, Amazon.com and Carbonado are trademarks or registered trademarks
+ * of Amazon Technologies, Inc. or its affiliates.  All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.amazon.carbonado.repo.jdbc;
+
+import com.amazon.carbonado.*;
+
+import java.sql.Connection;
+import java.sql.SQLException;
+
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+import static org.easymock.EasyMock.*;
+
+/**
+ * Tests for the JDBCTransactionManager.
+ *
+ * These tests mock out everything except the JDBCTransactionManager and
+ * JDBCTransaction.
+ *
+ * @author Jesse Morgan
+ */
+public class TestJDBCTransactionManager extends TestCase {
+    public static void main(String[] args) {
+        junit.textui.TestRunner.run(suite());
+    }
+
+    public static TestSuite suite() {
+        TestSuite suite = new TestSuite();
+        suite.addTestSuite(TestJDBCTransactionManager.class);
+        return suite;
+    }
+
+    private JDBCRepository mMockRepository;
+    private Connection mMockConnection;
+
+    /**
+     * Default Test Constructor.
+     */
+    public TestJDBCTransactionManager(String name) {
+        super(name);
+    }
+
+    /**
+     * Setup Mocks for the test.
+     */
+    @Override
+    protected void setUp() throws Exception {
+        super.setUp();
+
+        mMockConnection = createMock(Connection.class);
+
+        mMockRepository = createMock(JDBCRepository.class);
+        expect(mMockRepository.getConnectionForTxn(anyObject(IsolationLevel.class)))
+            .andReturn(mMockConnection)
+            .anyTimes();
+
+        expect(mMockRepository.getExceptionTransformer())
+            .andReturn(new JDBCExceptionTransformer())
+            .anyTimes();
+    }
+
+    /**
+     * Verify aborting a transaction rolls back and closes the connection.
+     */
+    public void testAbortTransaction() throws Exception {
+        // Expected Results
+        mMockConnection.rollback();
+        mMockRepository.closeConnection(mMockConnection);
+        replayAll();
+
+        // Run Test
+        JDBCTransactionManager txnManager = new JDBCTransactionManager(mMockRepository);
+        JDBCTransaction t = txnManager.createTxn(null, IsolationLevel.READ_COMMITTED);
+        txnManager.abortTxn(t);
+
+        // Verify Results
+        verifyAll();
+    }
+
+    /**
+     * Test that aborting a transaction closes the connection, even if an exception is thrown.
+     */
+    public void testAbortTransactionWhenThrows() throws Exception {
+        // Expected Results
+        mMockConnection.rollback();
+        expectLastCall().andThrow(new SQLException());
+        mMockRepository.closeConnection(mMockConnection);
+        replayAll();
+
+        // Run Test
+        JDBCTransactionManager txnManager = new JDBCTransactionManager(mMockRepository);
+        JDBCTransaction t = txnManager.createTxn(null, IsolationLevel.READ_COMMITTED);
+
+        try {
+            txnManager.abortTxn(t);
+            fail("Should have thrown.");
+        } catch (PersistException e) {
+            // Expected.
+        }
+
+        // Verify Results
+        verifyAll();
+    }
+
+    /**
+     * Test that aborting a transaction closes the connection, even if the repository is null.
+     */
+    public void testAbortTransactionWhenRepositoryClosed() throws Exception {
+        // Expected Results
+        mMockConnection.rollback();
+        mMockConnection.close();
+        replayAll();
+
+        // Create a txn.
+        JDBCTransactionManager txnManager = new JDBCTransactionManager(mMockRepository);
+        JDBCTransaction t = txnManager.createTxn(null, IsolationLevel.READ_COMMITTED);
+
+        // "Close" the repository.
+        mMockRepository = null;
+        System.gc();
+
+        // Abort should still close the connection.
+        txnManager.abortTxn(t);
+
+        // Verify Results
+        verify(mMockConnection);
+    }
+
+    /**
+     * Prepare all the mocks to be replayed.
+     */
+    private void replayAll() {
+        replay(mMockRepository, mMockConnection);
+    }
+
+    /**
+     * Verify all the mocks.
+     */
+    private void verifyAll() {
+        verify(mMockRepository, mMockConnection);
+    }
+
+}