From 80a4155021e36bccfd0f1a461c59f801cf685f4c Mon Sep 17 00:00:00 2001
From: "Brian S. O'Neill" <bronee@gmail.com>
Date: Wed, 11 Jan 2012 22:19:59 +0000
Subject: Make encoding strategy equals method symmetric in the face of
 subclassing.

---
 src/main/java/com/amazon/carbonado/gen/StorableGenerator.java | 1 +
 1 file changed, 1 insertion(+)

(limited to 'src/main/java/com/amazon/carbonado/gen')

diff --git a/src/main/java/com/amazon/carbonado/gen/StorableGenerator.java b/src/main/java/com/amazon/carbonado/gen/StorableGenerator.java
index ddde311..d372cf3 100644
--- a/src/main/java/com/amazon/carbonado/gen/StorableGenerator.java
+++ b/src/main/java/com/amazon/carbonado/gen/StorableGenerator.java
@@ -3055,6 +3055,7 @@ public final class StorableGenerator<S extends Storable> {
         b.returnValue(TypeDesc.BOOLEAN);
         notEqual.setLocation();
 
+        // FIXME: Using instanceof means that equals is not symmetric.
         // if (! target instanceof this) return false;
         TypeDesc userStorableTypeDesc = TypeDesc.forClass(mStorableType);
         b.loadLocal(b.getParameter(0));
-- 
cgit v1.2.3