diff options
| author | Brian S. O'Neill <bronee@gmail.com> | 2006-10-01 04:39:45 +0000 |
|---|---|---|
| committer | Brian S. O'Neill <bronee@gmail.com> | 2006-10-01 04:39:45 +0000 |
| commit | 24d905dfdabf03632e5968e88145f7101a219134 (patch) | |
| tree | 6eac9800b8f55775a3476d45be4ceef348e60e66 | |
| parent | 17cac5d7afae1fcc0461f725fdb5a074c1f71ea1 (diff) | |
Added FIXME comment for bug.
| -rw-r--r-- | src/main/java/com/amazon/carbonado/qe/DelegatedQueryExecutor.java | 1 | ||||
| -rw-r--r-- | src/main/java/com/amazon/carbonado/qe/JoinedQueryExecutor.java | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/src/main/java/com/amazon/carbonado/qe/DelegatedQueryExecutor.java b/src/main/java/com/amazon/carbonado/qe/DelegatedQueryExecutor.java index 7b1c27b..ef44963 100644 --- a/src/main/java/com/amazon/carbonado/qe/DelegatedQueryExecutor.java +++ b/src/main/java/com/amazon/carbonado/qe/DelegatedQueryExecutor.java @@ -136,6 +136,7 @@ public class DelegatedQueryExecutor<S extends Storable> implements QueryExecutor Filter<S> filter = query.getFilter();
// FIXME: this code can get confused if filter has constants.
if (values != null && filter != null && query.getBlankParameterCount() != 0) {
+ // FIXME: throws exception if not all values supplied
query = query.withValues(values.getValuesFor(filter));
}
return query;
diff --git a/src/main/java/com/amazon/carbonado/qe/JoinedQueryExecutor.java b/src/main/java/com/amazon/carbonado/qe/JoinedQueryExecutor.java index 62aab14..2272ecb 100644 --- a/src/main/java/com/amazon/carbonado/qe/JoinedQueryExecutor.java +++ b/src/main/java/com/amazon/carbonado/qe/JoinedQueryExecutor.java @@ -604,6 +604,7 @@ public class JoinedQueryExecutor<S extends Storable, T extends Storable> if (values == null) {
return null;
}
+ // FIXME: throws exception if not all values supplied
return mOuterLoopFilterValues.withValues(values.getValuesFor(mSourceFilterAsFromTarget));
}
|